Allow @variant to be used inside addBase#19480
Conversation
e6d54ab to
2b60ac9
Compare
RobinMalfait
left a comment
There was a problem hiding this comment.
I think this makes sense, we already handle @apply and we also handle @variant in the other JS based APIs.
Thanks!
Confidence Score: 5/5Safe to merge. The change is minimal and targeted, mirrors the pattern used in the main compilation path, and is backed by an inline snapshot test. The diff is a single extra line adding No files require special attention. Reviews (1): Last reviewed commit: "update changelog" | Re-trigger Greptile |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR adds support for using 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
This seems like an unintentional omission